feat(isLength): Fix linting and merge errors for #2019#2474
Merged
rubiin merged 44 commits intovalidatorjs:masterfrom Oct 16, 2024
Merged
feat(isLength): Fix linting and merge errors for #2019#2474rubiin merged 44 commits intovalidatorjs:masterfrom
rubiin merged 44 commits intovalidatorjs:masterfrom
Conversation
Improvement update Co-authored-by: Falk Schieber <12937991+pixelbucket-dev@users.noreply.github.com>
Co-authored-by: Falk Schieber <12937991+pixelbucket-dev@users.noreply.github.com>
Contributor
Author
|
Is it okay to ignore discreteLength parameter if it is not of type array? |
Contributor
Author
|
Requesting review @rubiin |
Member
|
There are several commits from other contributors? 44 commits. Can you perhaps only include your commit only |
rubiin
changed the title
Contributor
Author
|
@rubiin How do I do that? All other commits are from the original PR. |
Member
|
No worries then. I thought this was a fresh one |
profnandaa
approved these changes
Oct 16, 2024
rubiin
approved these changes
Oct 16, 2024
3 tasks
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(isLength): Fix linting and merge errors for #2019
Checklist