feat(isEmail): allow regexp in host_whitelist and host_blacklist#2494
Merged
WikiRik merged 6 commits intovalidatorjs:masterfrom Nov 21, 2024
Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2494 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 110 112 +2
Lines 2510 2526 +16
Branches 633 638 +5
===========================================
+ Hits 2510 2525 +15
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
Author
|
Appreciate a review of this PR 🙇♂️ |
WikiRik
approved these changes
Nov 21, 2024
Contributor
Author
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhance the host_whitelist and host_blacklist of isEmail validator to use regexp.
References: #562
Checklist