perf(module-runner): use module.registerHooks when available#20980
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Oct 22, 2025
Merged
Conversation
sapphi-red
added
p2-nice-to-have
sheremet-va
approved these changes
Oct 22, 2025
Member
Author
|
Tested with |
3 tasks
arcanis
added a commit
to yarnpkg/berry
that referenced
this pull request
Nov 7, 2025
## What's the problem this PR addresses? Node.js added support for a `conditions` flag in [`_resolveFilename`](https://github.com/nodejs/node/blob/525c4fb316a8074bea4e4aad358c3b376e99826c/lib/internal/modules/cjs/loader.js#L1340) (and thus indirectly [`require.resolve`](https://github.com/nodejs/node/blob/e72761fe5e855747012ba485df77c0e3da189b83/lib/internal/modules/helpers.js#L161-L166)), but they forgot to [document](https://nodejs.org/api/modules.html#requireresolverequest-options) this new option. As a result our hook rightfully refuses to perform the resolution since it doesn't know what to do with this flag. This is more an issue when using the new `registerHook` API because it then stops going into [this codepath](https://github.com/nodejs/node/blame/a7999c602cf7d70095dab3e5201d8c2f4b6a1867/lib/internal/modules/cjs/loader.js#L1051-L1055), causing a `conditions` option to always be injected. Vite recently [started](vitejs/vite#20980) using this API as of 7.2.0, so it now crashes. ## How did you fix it? Adds support for the `conditions` option (we already supported it, it's just that we weren't forwarding it, since Node.js didn't support it). ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I haven't actually tested whether this is more performant (I assume it is because a worker doesn't have to be spawned).
#20962 (comment)