Skip to content

Comments

[plugin-web-app] Add possibility to mock browser's HTTP requests#1135

Merged
valfirst merged 1 commit intomasterfrom
mocks
Dec 3, 2020
Merged

[plugin-web-app] Add possibility to mock browser's HTTP requests#1135
valfirst merged 1 commit intomasterfrom
mocks

Conversation

@ikalinin1
Copy link
Member

closes #1104

@ghost
Copy link

ghost commented Nov 13, 2020

DeepCode's analysis on #e37b5e found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Consider checking the presence of the optionals value with isPresent before accessing it with get Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1135 (e37b5ef) into master (c941f6c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1135      +/-   ##
============================================
+ Coverage     95.53%   95.54%   +0.01%     
- Complexity     4730     4748      +18     
============================================
  Files           624      627       +3     
  Lines         12875    12910      +35     
  Branches        933      935       +2     
============================================
+ Hits          12300    12335      +35     
  Misses          448      448              
  Partials        127      127              
Impacted Files Coverage Δ Complexity Δ
.../bdd/expression/DelegatingExpressionProcessor.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...ividus/bdd/expression/EvalExpressionProcessor.java 94.73% <ø> (ø) 5.00 <0.00> (ø)
...dus/bdd/expression/StringsExpressionProcessor.java 100.00% <ø> (ø) 12.00 <0.00> (ø)
...ividus/bdd/expression/DateExpressionProcessor.java 100.00% <ø> (ø) 13.00 <0.00> (ø)
...us/bdd/expression/DiffDateExpressionProcessor.java 100.00% <ø> (ø) 11.00 <0.00> (ø)
.../bdd/expression/FormatDateExpressionProcessor.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...dd/expression/FormatDateToExpressionProcessor.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...s/bdd/expression/ShiftDateExpressionProcessor.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...on/ConvertCsvToParquetFileExpressionProcessor.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
.../bdd/expression/FunctionalExpressionProcessor.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c941f6c...e37b5ef. Read the comment docs.

@ikalinin1 ikalinin1 force-pushed the mocks branch 3 times, most recently from 1d0de58 to b5375b2 Compare November 26, 2020 13:05
@ikalinin1 ikalinin1 force-pushed the mocks branch 7 times, most recently from 58af80e to 3694010 Compare November 27, 2020 09:34
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public interface IExpressionProcessor<T>
{
    Optional<T> execute(String expression);
}

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and in this case if you keep UnaryExpressionProcessor you won't need to change each and every expression processor

@ikalinin1 ikalinin1 force-pushed the mocks branch 3 times, most recently from 61593c7 to 727aafa Compare November 30, 2020 10:27
@ikalinin1 ikalinin1 requested a review from valfirst November 30, 2020 13:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit ffb180b into master Dec 3, 2020
@valfirst valfirst deleted the mocks branch December 3, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I would like to have the possibility to mock requests via proxy.

3 participants