Conversation
DeepCode's analysis on #e37b5e found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
uarlouski
reviewed
Nov 13, 2020
vividus/src/main/java/org/vividus/bdd/steps/BddVariableSteps.java
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Nov 13, 2020
vividus-tests/src/main/resources/properties/configuration.properties
Outdated
Show resolved
Hide resolved
vividus-plugin-web-app/src/test/java/org/vividus/proxy/steps/ProxyStepsTests.java
Outdated
Show resolved
Hide resolved
vividus-tests/src/main/resources/story/integration/ProxyStepsTests.story
Outdated
Show resolved
Hide resolved
vividus-tests/src/main/resources/story/integration/ProxyStepsTests.story
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
============================================
+ Coverage 95.53% 95.54% +0.01%
- Complexity 4730 4748 +18
============================================
Files 624 627 +3
Lines 12875 12910 +35
Branches 933 935 +2
============================================
+ Hits 12300 12335 +35
Misses 448 448
Partials 127 127
Continue to review full report at Codecov.
|
1d0de58 to
b5375b2
Compare
58af80e to
3694010
Compare
valfirst
requested changes
Nov 27, 2020
vividus-tests/src/main/resources/properties/configuration.properties
Outdated
Show resolved
Hide resolved
vividus-tests/src/main/resources/story/integration/ProxyStepsTests.story
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Nov 27, 2020
Collaborator
There was a problem hiding this comment.
public interface IExpressionProcessor<T>
{
Optional<T> execute(String expression);
}?
Collaborator
There was a problem hiding this comment.
and in this case if you keep UnaryExpressionProcessor you won't need to change each and every expression processor
vividus-bdd-engine/src/main/java/org/vividus/bdd/expression/RandomIntExpressionProcessor.java
Outdated
Show resolved
Hide resolved
vividus-bdd-engine/src/main/java/org/vividus/bdd/expression/FunctionalExpressionProcessor.java
Outdated
Show resolved
Hide resolved
61593c7 to
727aafa
Compare
valfirst
approved these changes
Dec 3, 2020
uarlouski
approved these changes
Dec 3, 2020
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1104