Skip to content

Comments

[extension-selenium] Gracefully handle interactions with non-started proxy#1177

Merged
valfirst merged 1 commit intomasterfrom
gracefully-handle-interactions-with-non-started-proxy
Nov 26, 2020
Merged

[extension-selenium] Gracefully handle interactions with non-started proxy#1177
valfirst merged 1 commit intomasterfrom
gracefully-handle-interactions-with-non-started-proxy

Conversation

@valfirst
Copy link
Collaborator

Fixes #1169

@valfirst valfirst force-pushed the gracefully-handle-interactions-with-non-started-proxy branch from dbe15bb to 5e8c1ad Compare November 26, 2020 14:21
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1177 (8787789) into master (1583120) will decrease coverage by 4.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1177      +/-   ##
============================================
- Coverage     95.52%   91.45%   -4.07%     
- Complexity     4717     4853     +136     
============================================
  Files           623      623              
  Lines         12840    12845       +5     
  Branches        930      930              
============================================
- Hits          12265    11748     -517     
- Misses          448      962     +514     
- Partials        127      135       +8     
Impacted Files Coverage Δ Complexity Δ
...elenium/src/main/java/org/vividus/proxy/Proxy.java 100.00% <100.00%> (ø) 25.00 <12.00> (+4.00)
.../main/java/org/vividus/runner/BddStepsCounter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...n/java/org/vividus/runner/BddScenariosCounter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...n/java/org/vividus/runner/KnownIssueValidator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...g/vividus/runner/VividusInitializationChecker.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...java/org/vividus/bdd/steps/VariableComparator.java 5.88% <0.00%> (-94.12%) 1.00% <0.00%> (+1.00%) ⬇️
...main/java/org/vividus/bdd/StatusStoryReporter.java 6.66% <0.00%> (-93.34%) 1.00% <0.00%> (+1.00%) ⬇️
vividus/src/main/java/org/vividus/bdd/Status.java 0.00% <0.00%> (-92.86%) 0.00% <0.00%> (ø%)
...c/main/java/org/vividus/configuration/Vividus.java 0.00% <0.00%> (-92.00%) 0.00% <0.00%> (ø%)
...c/main/java/org/vividus/bdd/steps/AssertSteps.java 10.00% <0.00%> (-90.00%) 1.00% <0.00%> (+1.00%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1583120...8787789. Read the comment docs.

@valfirst valfirst force-pushed the gracefully-handle-interactions-with-non-started-proxy branch from 5e8c1ad to 8787789 Compare November 26, 2020 15:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 88df73e into master Nov 26, 2020
@valfirst valfirst deleted the gracefully-handle-interactions-with-non-started-proxy branch November 26, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy steps are failing with NPE if no proxy started

2 participants