[plugin-mobile-app] Add steps to terminate and reinstall application#2092

VerkhovtsovPavel · 2021-10-20T09:00:47Z

Closes #2073

codecov · 2021-10-20T09:08:14Z

Codecov Report

Merging #2092 (f227d50) into master (0307563) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2092      +/-   ##
============================================
+ Coverage     96.20%   96.21%   +0.01%     
- Complexity     5347     5368      +21     
============================================
  Files           756      757       +1     
  Lines         15271    15338      +67     
  Branches       1028     1032       +4     
============================================
+ Hits          14692    14758      +66     
  Misses          450      450              
- Partials        129      130       +1

Impacted Files	Coverage Δ
.../vividus/bdd/mobileapp/steps/ApplicationSteps.java	`100.00% <100.00%> (ø)`
...g/vividus/mobileapp/action/ApplicationActions.java	`100.00% <100.00%> (ø)`
...org/vividus/bdd/mobileapp/steps/KeyboardSteps.java	`98.46% <0.00%> (-1.54%)`	⬇️
.../src/main/java/org/vividus/util/ResourceUtils.java	`100.00% <0.00%> (ø)`
...in/java/org/vividus/bdd/steps/ExecutableSteps.java	`100.00% <0.00%> (ø)`
...org/vividus/configuration/PropertiesDecryptor.java	`100.00% <0.00%> (ø)`
.../main/java/org/vividus/proxy/steps/ProxySteps.java	`100.00% <0.00%> (ø)`
...in/java/org/vividus/bdd/model/RequestPartType.java	`100.00% <0.00%> (ø)`
...n/java/org/vividus/bdd/steps/ui/web/WaitSteps.java	`100.00% <0.00%> (ø)`
...n/java/org/vividus/selenium/TimeoutConfigurer.java	`100.00% <0.00%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0307563...f227d50. Read the comment docs.

vividus-tests/src/main/resources/story/system/mobile_app/MobileAppStepsTests.story

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java

vividus-plugin-mobile-app/src/main/java/org/vividus/mobileapp/action/ApplicationActions.java

…action/ApplicationActions.java Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>

valfirst · 2021-10-29T14:00:52Z

appium/appium#15807 👀

valfirst · 2021-11-03T07:08:56Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

+
+[source,gherkin]
+----
+When I reinstall mobile application using bundle identifier `$bundleId`


Suggested change

When I reinstall mobile application using bundle identifier `$bundleId`

When I reinstall mobile application with bundle identifier `$bundleId`

valfirst · 2021-11-03T07:10:07Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

+|fullReset|true |
+
+----
+steps pair is ability to avoid device re-allocation on SauceLabs or BrowserStack in case of application re-installation within story run (e.g. in case usage ExamplesTable)


Suggested change

steps pair is ability to avoid device re-allocation on SauceLabs or BrowserStack in case of application re-installation within story run (e.g. in case usage ExamplesTable)

steps pair is ability to avoid device re-allocation on SauceLabs or BrowserStack in case of application re-installation within story run.

valfirst · 2021-11-03T07:11:01Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

+
+[source,gherkin]
+----
+When I reinstall mobile application using bundle identifier `$bundleId`


Please add a description for $bundleId parameter

valfirst · 2021-11-03T07:12:57Z

vividus-tests/src/main/resources/story/system/mobile_app/MobileAppStepsTests.story



+Scenario: Verify step: 'When I restart mobile application'
+When I restart mobile application


This test needs to be updated

uarlouski · 2021-11-03T07:48:03Z

vividus-plugin-mobile-app/src/main/java/org/vividus/mobileapp/action/ApplicationActions.java

+        HasCapabilities hasCapabilities = webDriverProvider.getUnwrapped(HasCapabilities.class);
+        String appPath = hasCapabilities.getCapabilities().getCapability("app").toString();
+        Validate.isTrue(interactor.removeApp(bundleId),
+                "Application with the bundle identifier '%s' hasn't been successfully removed", bundleId);


Maybe something simpler like "Unable to remove mobille application with the bundle identifier '%s'"

uarlouski · 2021-11-03T07:48:59Z

vividus-tests/src/main/resources/story/system/mobile_app/MobileAppStepsTests.story

 |app |${app-url}|


+Scenario: Verify step: 'When I restart mobile application'


please add requirement id for added scenarios

valfirst · 2021-11-04T07:06:45Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

+
+Remove a mobile application from device and install it again
+
+==== *_Parameters_*


this section should go after Wording

uarlouski · 2021-11-04T10:02:50Z

vividus-plugin-mobile-app/src/main/java/org/vividus/mobileapp/action/ApplicationActions.java

+                "Application with the bundle identifier '%s' is not installed or not running on the device",
+                bundleId);
+        Validate.isTrue(interactor.terminateApp(bundleId),
+                "Application with the bundle identifier '%s' hasn't been successfully terminated", bundleId);


"Unable to terminated mobile application with the bundle identifier '%s'" to follow common pattern?

docs/modules/plugins/pages/plugin-mobile-app.adoc

ikalinin1 · 2021-11-05T07:19:12Z

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java

    }

+    /**
+     * Restart mobile application


Steps wording mentions reinstall, javadoc says about restart, looks confusing for the end user

ikalinin1 · 2021-11-05T07:20:55Z

vividus-tests/src/main/resources/story/system/mobile_app/MobileAppStepsTests.story

+Scenario: Verify step: 'When I reinstall mobile application with bundle identifier `$bundleId`'
+Meta:
+    @requirementId 2073
+When I reinstall mobile application with bundle identifier `${main-app}`


No validations here?

For example, you could open some view, validate it opened, and then reinstall. In the current implementation of the test, if step does nothing at all we won't get any error

Co-authored-by: Ivan Kalinin <ivan_kalinin1@epam.com>

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java

VerkhovtsovPavel marked this pull request as ready for review October 20, 2021 09:43

ikalinin1 requested review from abudevich, ikalinin1, uarlouski and valfirst October 20, 2021 10:05

ikalinin1 reviewed Oct 20, 2021

View reviewed changes

vividus-tests/src/main/resources/story/system/mobile_app/MobileAppStepsTests.story Outdated Show resolved Hide resolved

valfirst requested changes Oct 20, 2021

View reviewed changes

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java Outdated Show resolved Hide resolved

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java Outdated Show resolved Hide resolved

valfirst reviewed Oct 20, 2021

View reviewed changes

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java Outdated Show resolved Hide resolved

valfirst requested changes Oct 25, 2021

View reviewed changes

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java Outdated Show resolved Hide resolved

vividus-plugin-mobile-app/src/main/java/org/vividus/mobileapp/action/ApplicationActions.java Outdated Show resolved Hide resolved

VerkhovtsovPavel and others added 7 commits October 29, 2021 14:02

[plugin-mobile-app] Add steps for terminate and restart application

75353dc

Fix checkstyle issues

90b47fa

Update based on review comments

1e1e27d

Update vividus-plugin-mobile-app/src/main/java/org/vividus/mobileapp/…

d2cf2b9

…action/ApplicationActions.java Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>

Small tests update

ca79fe7

Extended documentation for reset step

a9983e6

Fix checkstyle issues

15da352

VerkhovtsovPavel force-pushed the mobile-app-add-steps-for-terminate-and-restart-application branch from b772291 to 15da352 Compare October 29, 2021 11:25

Rework restart step to reinstall

7dd7ad7

valfirst requested changes Nov 3, 2021

View reviewed changes

uarlouski reviewed Nov 3, 2021

View reviewed changes

Update based on review comments

093bf76

valfirst requested changes Nov 4, 2021

View reviewed changes

Move Parameters section

61436d0

valfirst approved these changes Nov 4, 2021

View reviewed changes

valfirst changed the title ~~[plugin-mobile-app] Add steps for terminate and restart application~~ [plugin-mobile-app] Add steps to terminate and reinstall application Nov 4, 2021

valfirst requested review from ikalinin1 and uarlouski November 4, 2021 09:43

uarlouski reviewed Nov 4, 2021

View reviewed changes

Update message for terminate action

fef30f1

ikalinin1 reviewed Nov 5, 2021

View reviewed changes

docs/modules/plugins/pages/plugin-mobile-app.adoc Outdated Show resolved Hide resolved

ikalinin1 reviewed Nov 5, 2021

View reviewed changes

Fix typo in example

5535590

Co-authored-by: Ivan Kalinin <ivan_kalinin1@epam.com>

valfirst reviewed Nov 5, 2021

View reviewed changes

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/ApplicationSteps.java Outdated Show resolved Hide resolved

valfirst and others added 2 commits November 5, 2021 18:17

Fix Javadoc

cd27106

Update mobile application reinstallation test

f227d50

valfirst requested review from ikalinin1 and uarlouski November 5, 2021 15:58

uarlouski approved these changes Nov 5, 2021

View reviewed changes

ikalinin1 approved these changes Nov 8, 2021

View reviewed changes

valfirst merged commit b2ee00d into vividus-framework:master Nov 8, 2021

	When I reinstall mobile application using bundle identifier `$bundleId`
	When I reinstall mobile application with bundle identifier `$bundleId`

	steps pair is ability to avoid device re-allocation on SauceLabs or BrowserStack in case of application re-installation within story run (e.g. in case usage ExamplesTable)
	steps pair is ability to avoid device re-allocation on SauceLabs or BrowserStack in case of application re-installation within story run.



		Scenario: Verify step: 'When I restart mobile application'
		When I restart mobile application

		\|app \|${app-url}\|


		Scenario: Verify step: 'When I restart mobile application'


		Remove a mobile application from device and install it again

		==== _Parameters_

Uh oh!

Comments

Conversation

VerkhovtsovPavel commented Oct 20, 2021

Uh oh!

codecov bot commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valfirst commented Oct 29, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Oct 20, 2021 •

edited

Loading