Draft
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Draft
Merging this PR will degrade performance by 18.01%
Performance Changes
Comparing Footnotes
|
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR implements a new
Meanaggregate function for computing the arithmetic mean of numeric values in Vortex arrays.The implementation includes:
Meanstruct that implements theAggregateFnVTabletraitMeanAccumulatorthat maintains running sum and count statisticsAggregateFnSessionThe accumulator efficiently processes batches by converting all numeric types to f64 and tracking valid values based on the array's validity mask. It supports flushing intermediate results for grouped operations and merging state from other accumulators for distributed computation.
Testing
The implementation includes comprehensive unit tests covering:
All tests verify correct f64 output values and proper null handling in edge cases.