Skip to content

Comments

fix: double require problem#2667

Closed
rishabh3112 wants to merge 23 commits intomasterfrom
fix/double-require-prob
Closed

fix: double require problem#2667
rishabh3112 wants to merge 23 commits intomasterfrom
fix/double-require-prob

Conversation

@rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Apr 26, 2021

What kind of change does this PR introduce?
Fix

Did you add tests for your changes?
N/A

If relevant, did you update the documentation?
N/A

Summary
Fix double require problem. Described as in webpack/webpack-dev-server#3219

Does this PR introduce a breaking change?
No

Other information
No

@rishabh3112
Copy link
Member Author

Not working on windows 😞 . @webpack/cli-team can you help?

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #2667 (2a15e15) into master (111fa64) will decrease coverage by 1.39%.
The diff coverage is 76.00%.

❗ Current head 2a15e15 differs from pull request most recent head 0fb4bdd. Consider uploading reports for the commit 0fb4bdd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2667      +/-   ##
==========================================
- Coverage   96.06%   94.67%   -1.40%     
==========================================
  Files          30       30              
  Lines        1526     1520       -6     
  Branches      432      432              
==========================================
- Hits         1466     1439      -27     
- Misses         60       81      +21     
Impacted Files Coverage Δ
packages/webpack-cli/bin/cli.js 69.56% <53.84%> (+2.89%) ⬆️
packages/webpack-cli/lib/utils/package-exists.js 100.00% <100.00%> (ø)
...kages/webpack-cli/lib/utils/prompt-installation.js 73.91% <100.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 96.70% <100.00%> (-0.46%) ⬇️
packages/webpack-cli/lib/utils/logger.js 88.88% <0.00%> (-11.12%) ⬇️
packages/webpack-cli/lib/plugins/CLIPlugin.js 90.47% <0.00%> (-9.53%) ⬇️
packages/serve/src/startDevServer.ts 84.21% <0.00%> (-8.78%) ⬇️
packages/serve/src/index.ts 85.93% <0.00%> (-4.69%) ⬇️
packages/generators/src/init-generator.ts 94.23% <0.00%> (-3.85%) ⬇️
packages/generators/src/addon-generator.ts 88.63% <0.00%> (-2.60%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111fa64...0fb4bdd. Read the comment docs.

@rishabh3112 rishabh3112 marked this pull request as ready for review April 28, 2021 15:13
@rishabh3112 rishabh3112 requested a review from a team as a code owner April 28, 2021 15:13
@rishabh3112
Copy link
Member Author

Closing this in favour of #2716

@rishabh3112 rishabh3112 deleted the fix/double-require-prob branch May 14, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants