Don't handle impossible errors in HostResolveImportedModule#2625
Merged
Don't handle impossible errors in HostResolveImportedModule#2625
Conversation
This was referenced May 4, 2017
domenic
commented
May 4, 2017
| <li><p>Let <var>resolved module script</var> be <var>moduleMap</var>[<var>url</var>]. (This entry | ||
| must <span data-x="map exists">exist</span> for us to have gotten to this point.)</p></li> | ||
|
|
||
| <li> |
Member
Author
GeorgNeis
approved these changes
May 12, 2017
GeorgNeis
left a comment
GeorgNeis
left a comment
There was a problem hiding this comment.
rubberstamp lgtm to unblock larger revisions
Several of the cases that were handled as errors are actually impossible to hit. Instead of throwing errors in these impossible situations, we can just assert that they are impossible. This also cleans up "resolve a module specifier" and the module map to be clear that they operate on URL records, not on absolute URL strings.
domenic
force-pushed
the
remove-impossible-module-error-cases
branch
from
56b7bcb to
2a286f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't handle impossible errors in HostResolveImportedModule
Several of the cases that were handled as errors are actually impossible
to hit. Instead of throwing errors in these impossible situations, we
can just assert that they are impossible.
This also cleans up "resolve a module specifier" and the module map to
be clear that they operate on URL records, not on absolute URL strings.
Builds on top of #2604 (which itself builds on top of #2595), so should not be merged until those are. But that commit can be reviewed separately, and I guess if it gets reviewed first I can rebase things on top of it.
@GeorgNeis to review, as he found this issue.
Preview of this at https://dl.dropboxusercontent.com/u/20140634/modules-all-better/index.html