Enhanced object literals support#39
Merged
okuryu merged 2 commits intoyahoo:masterfrom Dec 24, 2018
kwolfy:master
Merged
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
/cc @kwolfy looks it is require accept CLA, can you accept? |
|
/cc @okuryu can you review PR? |
Contributor
Author
|
I accepted |
|
/cc @redonkulus |
This comment was marked as outdated.
This comment was marked as outdated.
|
/cc @okuryu |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
OK, let's review.. It seems not to have tests for |
|
@okuryu yep, but we run test on node@4 and it is impossible to test |
Contributor
Author
|
right |
Collaborator
|
oops! I see 😅 |
|
/cc @okuryu can we merge this and release new version? We have some problems in |
Collaborator
|
Sorry for delay! I just merged and published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I could not cover the case with async enhanced object literals, cause in travis CI you have nodejs=4 tests
Fix #33