fix: correctly install implicit nested types dependencies

[spanishpear]

What's the problem this PR addresses?

Closes #6442

By default - yarn will automatically add @types/foo for a package, if the package
has a peer dependency on foo. This happens in the normalizePackage core,
and exists as packages often don't specify the correct peer dependencies.

However, given a scenario where:

"dependencies": {
    "peer-deps-implicit-types-conflict": "1.0.0",
    "@types/no-deps": "1.0.0",
}

where peer-deps-implicit-types-conflict has a dependency on @types/no-deps:2.0.0,

  "dependencies": {
    "@types/no-deps": "2.0.0"
  },
  "peerDependencies": {
    "no-deps": "1.0.0"
  }

yarn will only install @types/no-deps:1.0.0 - even though @types/no-deps: 2.0.0 is specified
as a dependency!

How did you fix it?

The fix is rather trivial and thanks to the helpful comment here - #6442 (comment) - simply don't install the automatic @types/foo for a package that has foo as a peer-dependency, if the package already specifies @types/foo as a dependency.

There is already logic for this behavior when it comes to @types/ already existing in peerDependencies or peerDependenciesMeta - this PR just extends that to dependencies as well.
...

Checklist

• I have read the Contributing Guide.

• I have set the packages that need to be released for my changes to be effective.

• I will check that all automated PR checks pass before the PR gets reviewed.

[spanishpear]

Here you can see the impact of the fix :D All of these packages specified @types/react as dependency but yarn added an automatic @types/react when it didn't need to

[clemyan]

🤔 Can't tell if these being deps rather than peers is correct or not after a cursory look but this change is correct regardless -- if it is problematic then those are bugs that should be fixed upstream.

[spanishpear]

Any opinions on what changeset this should be?

Strictly speaking, it could be considered a breaking change in behavior, but IMO it's is more accurately a minor? 🤔

The failing tests look like flakes unrelated to the changeset.

[clemyan]

I'd consider this a bugfix so patch should suffice

[spanishpear]

@clemyan I've added a patch changeset following the interactive tool - let me know if you want any further changes! ❤️

[arcanis]

Thanks @spanishpear !