fix(plugin-nm): set binary permissions for partial installs

[oskarols]

Hi! 👋

What's the problem this PR addresses?

Resolves #5344 #6551

When using nodeLinker: node-modules there's an issue where bin files sometimes don't have the correct permissions (755) after installation. Some examples of scenarios where this can occur:

1. Deleting a package directory containing a bin file in node_modules and then running yarn install
2. Upgrading a package containing a bin file
3. Using a stale node_modules (e.g. when using a CI cache) and then running yarn install

I ran a bisect and at least scenario 1 above seems to have started in 3.2.1, I suspect it's this change specifically although previous to this change the deleted directory was not reinstalled at all.

Digging into the issue I found that the general issue stems from reliance on presence of symlinks inside node_modules/.bin/ (here) to check whether permissions should be re-applied. The flaw with this approach is that for stale installation the old symlink is still there e.g. if a new version of a package is installed.

How did you fix it?

This changes the prevBinSymlinks to remove all symlinks that were related to added/changed packages during the installation. The comparison between previous and current symlinks inside persistBinSymlinks will now recreate the symlinks for these updated packages and also set the correct permissions.

I've added two tests which were previously failing to cover this behavior, and a third which was already succeeding since it seemed sensible to explicitly test for permissions in a basic test as well.

Checklist

• I have read the Contributing Guide.

• I have set the packages that need to be released for my changes to be effective.

• I will check that all automated PR checks pass before the PR gets reviewed.

[oskarols]

General question: browsing the commit history it seems that the PRs description seem to be used for the commits. Is this done automatically upon merge? Or do you want me to write a detailed commit description by hand?

[larixer]

General question: browsing the commit history it seems that the PRs description seem to be used for the commits. Is this done automatically upon merge? Or do you want me to write a detailed commit description by hand?

I think it's done automatically. We just squash-merge PRs

[larixer]

Thanks, look good to me!

[oskarols]

@larixer Thanks for the reviews and help!

Any clue on when this would be released? Is there anything I can do to get this out the door?

[arcanis]

I'll review a couple of other PRs later today and make a release