Add Target option for copying frameworks when installing#912
Add Target option for copying frameworks when installing#912yonaskolb merged 6 commits intoyonaskolb:masterfrom
Conversation
A good start is the fixture tests, so we can confirm the actual project output. |
|
@brentleyjones Added a test case to parse the JSON dictionary as well as the flag to a target in our yaml sample. Not sure where to assert that the right changes in the resulting project file occurred though. |
|
Thanks @jsorge! It might be useful to also set a In terms of the fixture test, I can see that it led to a diff and that's enough. That's used a simple integration and snapshot test. Uncommitted diffs and compilation errors cause a failure on CI. Could you also add a changelog entry. |
|
@yonaskolb Thanks for the feedback! Addressed everything except the Carthage build phase, since I'm not sure how that works. My mental model is to have this mirror Xcode's checkbox (which is linked in issue #608). How does Carthage interact with the "Embed Frameworks" build phase? |
|
@jsorge the generated Carthage build step basically extracts and copies the frameworks in, which is similar. I'm happy to leave this PR focused though. Thanks again! |
|
@jsorge thanks! |
There's a checkbox in a target's Embed Frameworks step that says "copy only when installing", and it defaults to un-selected. This PR adds the
onlyCopyFilesOnInstallflag toTargetwhich will check that box.This resolves #608.