Skip to content

Comments

[Rector] Add rector to require-dev and use single autoload vendor for run PHPUnit#1001

Merged
nikophil merged 12 commits intozenstruck:2.xfrom
samsonasik:use-single-autoload
Oct 9, 2025
Merged

[Rector] Add rector to require-dev and use single autoload vendor for run PHPUnit#1001
nikophil merged 12 commits intozenstruck:2.xfrom
samsonasik:use-single-autoload

Conversation

@samsonasik
Copy link
Contributor

@nikophil since the approved solution is the patch on rector bootstrap, the only way to work on your use case on this repo is use rector/rector on your require-dev, and remove the autoload of rector autoload, since it already loaded early.

Copy link

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomasVotruba
Copy link

@samsonasik Seems "Static analysis" job needs path update

@samsonasik
Copy link
Contributor Author

@TomasVotruba sure 👍 , updated phpstan paths at next commits cba0b34 and 1b1b5ad

@samsonasik
Copy link
Contributor Author

@nikophil MakeFactoryTest seems flip flop change lookup directory tools, I guess you can take care the rest from here :)

@samsonasik
Copy link
Contributor Author

@nikophil @TomasVotruba Finally 🎉 , All green 🎉🎉🎉 Ready to merge 👍

Copy link

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

Copy link
Member

@nikophil nikophil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we also need to remove ./tools/bin/rector

I'll do this in a further PR.

thanks a lot for your help 👍

@nikophil nikophil merged commit 660942d into zenstruck:2.x Oct 9, 2025
74 checks passed
@samsonasik samsonasik deleted the use-single-autoload branch October 9, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants