Fix context class test stability - #51
Merged
Merged
Conversation
jjgrainger
added
[Type] Enhancement
mukeshpanchal27
approved these changes
Jan 5, 2023
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
Member
There was a problem hiding this comment.
Thanks @jjgrainger, Great work.
bordoni
added a commit
that referenced
this pull request
Sep 13, 2023
* Include a way to modify the PHP Binary Path Move the PHP CLI path building to it's own class, enabling the PHPCS class to have proper separation of concerns. In this PR I included the possibility for someone to modify the PHP Binary path that will be used to Run the PHP Code Sniffer. * Fix a typo on the Class name docblock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments in #47 (comment)
TESTS_PLUGIN_DIRconstant when creating instances of thePlugin_ContextandCheck_Contextclasses in unit tests.TESTS_PLUGIN_DIRis equal to/var/www/html/wp-content/plugins/plugin-check/.__FILE__constant (seen inplugin-check.phpfile and creates the same expected full path, e.g/var/www/html/wp-content/plugins/plugin-check/WP_PLUGIN_DIR . '\'