Skip to content

feat: add too_many_attempts error to passwordless - #2700

Merged
ankita10119 merged 2 commits into
auth0:masterfrom
avamachado-okta:eup-23-bfp-error
Dec 22, 2025
Merged

ankita10119 merged 2 commits into
auth0:masterfrom
avamachado-okta:eup-23-bfp-error

Conversation

@avamachado-okta

@avamachado-okta avamachado-okta commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Changes

Add Brute-Force Protection too_many_attempts error to passwordless error mappings to support adding Brute-Force Protection to passwordless/start endpoint

References

https://auth0team.atlassian.net/browse/EUP-23

Testing

This was tested alongside changes to enforce Brute-Force Protection on the passwordless/start endpoint behind a feature flag. The error is not currently emitted in this location.

  1. block user
  2. attempt passwordless login
  3. user will be blocked from continuing login since no Brute-Force Protection attempts remain
Screenshot 2025-12-08 at 9 56 36 AM Screenshot 2025-12-08 at 11 27 59 AM

The current behavior without this change just shows generic error when Brute-Force Protection is enforced and the feature flag is enabled:
Screenshot 2025-12-08 at 11 54 12 AM

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@avamachado-okta
avamachado-okta requested a review from a team as a code owner December 8, 2025 19:38
@avamachado-okta
avamachado-okta marked this pull request as draft December 8, 2025 21:24
@avamachado-okta
avamachado-okta marked this pull request as ready for review December 17, 2025 19:59
@codecov

codecov Bot commented Dec 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.52%. Comparing base (e89a37d) to head (18051c2).
⚠️ Report is 56 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2700      +/-   ##
==========================================
+ Coverage   42.54%   43.52%   +0.97%     
==========================================
  Files         120      120              
  Lines        3145     3180      +35     
  Branches      337      339       +2     
==========================================
+ Hits         1338     1384      +46     
+ Misses       1713     1701      -12     
- Partials       94       95       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankita10119

Copy link
Copy Markdown
Contributor

@claude

1 similar comment
@ankita10119

Copy link
Copy Markdown
Contributor

@claude

@ankita10119 ankita10119 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified these changes locally. Looks good to me.
Screenshot 2025-12-19 at 3 52 49 PM

@ankita10119
ankita10119 merged commit 00124da into auth0:master Dec 22, 2025
6 of 7 checks passed
@ankita10119 ankita10119 mentioned this pull request Jan 12, 2026
ankita10119 added a commit that referenced this pull request Jan 12, 2026
**Added**
- feat: add too_many_attempts error to passwordless
[\#2700](#2700)
([avamachado-okta](https://github.com/avamachado-okta))

**Changed**
- Update: Upgrade Node.js from 18 to 22
[\#2711](#2711)
([ankita10119](https://github.com/ankita10119))
ankita10119 added a commit that referenced this pull request Aug 17, 2026
…all locales (#2839)

### Changes

Adds the too_many_attempts error message to the error.passwordless
section in all 44 locale files, bringing v13 to parity with master.

Also relaxes the i18n sanitizer test assertion from an exact string
match to regex matchers, making it resilient to attribute ordering
differences across sanitizer versions.

No API or UI changes.

### References

- #2700 - "feat: add too_many_attempts error to passwordless" 

### Testing

* [ ] This change adds unit test coverage
* [ ] This change adds integration test coverage
* [ ] This change has been tested on the latest version of the
platform/language

Existing i18n test suite passes. The sanitizer test (should sanitize the
input and not allow for javascript to be passed through) was updated to
verify attributes individually rather than asserting a fixed output
string.

### Checklist

* [ ] I have read the [Auth0 general contribution
guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md)
* [ ] I have read the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md)
* [ ] All code quality tools/guidelines have been run/followed
* [ ] All relevant assets have been compiled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants