[6.x] Asset transformers - #19464
[6.x] Asset transformers#19464
Conversation
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
7427360 to
4c98c53
Compare
7a6c7e5 to
b52cb20
Compare
332aff6 to
87047e0
Compare
87047e0 to
61efb76
Compare
There was a problem hiding this comment.
FYI: I only reviewed the spec doc, not the implementation.
I’m not sold on some of the terminology:
processorreads like a new synonym fortransformer.transformandtransformermay carry baggage, but they’re established terms and clearly describe the relationship.
I understand why the model needs three levels, but names rooted in the existing transform terminology feel clearer:
AssetTransform/AssetTransformRequestAssetTransformerAssetTransformDriver
rendition feels awkward. It doesn’t appear in the public API and only occurs in production code in an error message. What about transform result, output, or even variant (Commerce Variants)?
operations and operationFields feel awkward. options / optionFields, settings, config feel more natural. “Operations” also seems to suggest discrete steps applied in succession, but these appear to be parameters that are normalized and passed to the driver.
…mers # Conflicts: # yii2-adapter/legacy/config/GeneralConfig.php
|
This PR had conflicts with Claude's response
|
|
This PR had conflicts with Claude's response
|
See https://github.com/craftcms/cms/blob/feature/asset-transformers/docs/asset-transformers.md