Skip to content

docs: fix documentation on strides - #1473

Merged
Ralith merged 3 commits into
dimforge:mainfrom
wowinter13:fix-strides-docs
Jun 6, 2025
Merged

Ralith merged 3 commits into
dimforge:mainfrom
wowinter13:fix-strides-docs

Conversation

@wowinter13

@wowinter13 wowinter13 commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Resolves #1217

@wowinter13

Copy link
Copy Markdown
Contributor Author

@Ralith Could you please check this one?

@Ralith

Ralith commented Mar 19, 2025

Copy link
Copy Markdown
Collaborator

I see why you found the current text misleading, but I don't find the new text much clearer; I still had to stare at them both for a few minutes to understand what was going on.

How about something like "the relative offset in the underlying storage corresponding to a change in position by one row or column respectively"?

@wowinter13

Copy link
Copy Markdown
Contributor Author

@Ralith thanks, addressed!
Sorry for the delay – forgot about this PR

@Ralith

Ralith commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

No worries.

@Ralith
Ralith merged commit fa7afd5 into dimforge:main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing documentation on strides

2 participants