Skip to content

feat(create-electron-app)!: move init and import out of core - #4148

Merged
erickzhao merged 32 commits into
nextfrom
move-bootstrap-to-cea
Mar 11, 2026
Merged

feat(create-electron-app)!: move init and import out of core#4148
erickzhao merged 32 commits into
nextfrom
move-bootstrap-to-cea

Conversation

@erickzhao

@erickzhao erickzhao commented Feb 25, 2026

Copy link
Copy Markdown
Member

BREAKING CHANGE: init and import now exist in the create-electron-app module

Forge's monorepo is structured such that the @electron-forge/core module handles all API commands. These fit under two broad categories: bootstrapping (init, import) and building (package, make, publish).

This approach has a huge downside: you don't really need init or import once your project is already set up, but incorporating packages such as @electron-forge/template-webpack as a transitive dependency to @electron-forge/core artificially inflates Forge's node_modules tree.

This PR attempts to separate these bootstrap commands by moving their business logic and dependencies into create-electron-app.

@erickzhao erickzhao changed the title refactor(create-electron-app): move refactor(create-electron-app): move init and import out of core Feb 25, 2026
@erickzhao erickzhao changed the title refactor(create-electron-app): move init and import out of core feat(create-electron-app)!: move init and import out of core Feb 25, 2026
@socket-security

socket-security Bot commented Feb 25, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​electron/​lint-roller@​3.2.0 ⏵ 3.1.3841008688 -1100
Added@​electron-forge/​cli@​0.0.0-use.local100100100100100

View full report

@erickzhao erickzhao added the next label Mar 4, 2026
@erickzhao
erickzhao force-pushed the move-bootstrap-to-cea branch from 9387582 to 420a755 Compare March 5, 2026 23:49
@erickzhao
erickzhao marked this pull request as ready for review March 6, 2026 21:48
@erickzhao
erickzhao requested a review from a team as a code owner March 6, 2026 21:48
@erickzhao erickzhao mentioned this pull request Mar 6, 2026
24 tasks
@erickzhao
erickzhao merged commit 2a59a48 into next Mar 11, 2026
11 checks passed
@erickzhao
erickzhao deleted the move-bootstrap-to-cea branch March 11, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants