feat(template): replace eslint/prettier with oxc.rs stack - #4186
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
erickzhao
marked this pull request as ready for review
March 28, 2026 00:08
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
erickzhao
marked this pull request as draft
April 15, 2026 01:05
erickzhao
marked this pull request as ready for review
April 15, 2026 04:49
MarshallOfSound
approved these changes
Apr 17, 2026
erickzhao
enabled auto-merge (squash)
April 17, 2026 19:46
erickzhao
disabled auto-merge
April 17, 2026 19:57
Member
Author
|
7c4251a applies linting consistently across all non-base templates via a shared |
dsanders11
approved these changes
Apr 17, 2026
dsanders11
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4170.
I figured we might as well migrate to
oxfmtif we're going to useoxlintfor the templates and provide both to users.Note that we previously didn't ship any formatting to users, so this is a nice-to-have.
This PR:
eslintforoxlintin the template initialization codeprettierforoxfmt.oxfmtrc.jsonwith existing rules.oxfmtrc.jsonfrom the root of the repo to each template (while deletingignorePaths)BaseTemplateinitialization where there was no way to remove a line when programatically splicing files (nownullreturn values delete the line)