Remove fluent-ffmpeg and directly invoke ffmpeg instead - #333
Merged
Merged
Conversation
dahlia
requested changes
Jan 19, 2026
dahlia
left a comment
dahlia
left a comment
Member
There was a problem hiding this comment.
Sorry, could you run pnpm exec biome format --write? Also you need to rebase your commit on the latest main!
Contributor
Author
|
Should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was intended as a fix for #324, but that was actually a different issue 🫠 Still, fluent-ffmpeg is no longer supported and any issue when creating a screenshot would stop the entire upload. So the PR is still helpful, I hope ;)
The most interesting change is that on error, the ffmpeg output is logged (and should give some insights into why it failed) and a "default" screenshot is returned (the hollo logo) instead of aborting the request.