Skip to content

Typedefinition for dialog.closeByBackdropClick Default Value is wrong #3917

Description

@schlundus
  • Framework7 version: 6.0.22

Describe the bug

The type definition in dialog.d.ts is saying that the default for dialog.closeByBackdropClick is true
--schnipp--
/** When enabled, dialog will be closed on backdrop click. (default true) */
closeByBackdropClick?: boolean;
--schnapp--

But the default in the code (dialog.js) is false (also in the website documentation)
--schnipp--
...
closeByBackdropClick: false,
...
-schnapp---

so the type definition is wrong here

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions