test(flakeref): use cached GNU hello instead of process-compose - #2878
Merged
Merged
Conversation
The flakeref add test pulled `github:F1bonacc1/process-compose` at a pinned tag, which had to be built and required bumping the tag over time. Swap it for GNU hello pinned to a fixed nixpkgs commit: it is tiny, available in the binary cache (no build), and the commit never changes, so the test is fast and stable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the add_platforms_flakeref test by replacing a pinned process-compose GitHub flake (which required building and periodic tag bumps) with a pinned Nixpkgs hello output that should be available from the binary cache, making the test faster and less flaky.
Changes:
- Switch
devbox addin the flake-ref test fromgithub:F1bonacc1/process-compose/v1.87.0togithub:nixos/nixpkgs/<fixed-commit>#hello. - Update the runtime assertion to execute
helloand validate its output. - Update the expected
devbox.jsonsuperset to reflect the new flake ref key.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from
mikeland73/fix-flaky-cicd-tests(1/5).The flakeref
addtest pulledgithub:F1bonacc1/process-composeat a pinned tag, which had to be built and required periodically bumping the tag. Swap it for GNUhellopinned to a fixed nixpkgs commit: it is tiny, available in the binary cache (no build), and the commit never changes — so the test is fast and stable.🤖 Generated with Claude Code