fix(examples): drop unused cowboy dep from elixir example - #2882
Merged
Merged
Conversation
The elixir_hello example only prints "Hello World!" and never uses cowboy. Pulling the unused hex dependency forced `mix run` to install Hex over the network, which fails under Erlang/OTP 27.2 due to a strict cert key-usage check rejecting builds.hex.pm (key_usage_mismatch TLS alert). Removing the dead dependency makes the example fully offline so `devbox run run_test` no longer touches the network. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the examples/development/elixir/elixir_hello template fully offline by removing an unused Hex dependency that caused Mix to attempt network access during mix run in CI.
Changes:
- Removed the unused
{:cowboy, "~> 2.9"}dependency frommix.exs. - Deleted
mix.locksince it only contained lock entries for the removed dependency tree.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/development/elixir/elixir_hello/mix.exs | Drops the unused cowboy dependency from the example’s dependency list. |
| examples/development/elixir/elixir_hello/mix.lock | Removes the lockfile that only existed due to the unused dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
elixir_helloexample'srun_test(mix run) was failing in CI with a TLSkey_usage_mismatchalert when Mix tried to install Hex frombuilds.hex.pm— a strict certificate check in the pinned Erlang/OTP 27.2. Mix only reached out to the network because the example declared a hex dependency oncowboy, which is entirely unused (lib/elixir_hello.exjust prints "Hello World!"). This PR removes the deadcowboydependency (and the now-emptymix.lock), making the example fully offline so the test no longer touches the network.How was it tested?
Reproduced the original CI failure locally, then confirmed
devbox run run_testnow compiles and printsHello World!from a clean_build/depswith no network access.Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.