fix(examples/jekyll): pin ruby@3.1 back to 3.1.4 for macOS - #2984
Merged
Merged
Conversation
The ruby_3_1 (3.1.7) build pinned in #2974 is missing the socket extension on aarch64-darwin, so `gem install` fails with `uninitialized constant Gem::Commands::InstallCommand` (masking a `LoadError: cannot load such file -- socket`). This broke the nightly macOS project tests. Restore the previous 3.1.4 lock entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
@claude ptal |
|
Claude finished @mikeland73's task in 1m 1s —— View job Review: PR #2984
LGTM. The fix is a clean, well-scoped lockfile-only change:
I can't independently verify the Nix store hashes/build outputs in this sandbox (no No changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the nightly
cli-testsfailure instacks_jekyll_run_teston macOS (e.g. run 35838473204), failing every scheduled run since #2974. That PR bumpedruby@3.1to 3.1.7 (nixpkgs/bce5fe2b#ruby_3_1), whose aarch64-darwin build lacks thesocketextension, sogem installfails withuninitialized constant Gem::Commands::InstallCommand(maskingLoadError: cannot load such file -- socket). This restores the previous 3.1.4 lock entry, same as #2974 did forlibffiandstack; #2974's own CI missed it because macOS only runs on schedule or withrun-mac-tests.How was it tested?
Locally on arm64 macOS:
DEVBOX_RUN_PROJECT_TESTS=1 go test ./testscripts -run TestExamples/stacks_jekyll_run_testpasses with this change and fails with the same error on the currentmainlockfile.Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.
🤖 Generated with Claude Code