shellIntegrationAddon.ts: only decode messages for VSCodeOScPt, not iTerm2 - #165579
Merged
Daniel Imms (Tyriar) merged 2 commits intoNov 23, 2022
Merged
Conversation
Robert Estelle (rwe)
force-pushed
the
shellint-no-decode-iterm2
branch
from
November 6, 2022 21:55
5b03427 to
3e49113
Compare
Robert Estelle (rwe)
force-pushed
the
shellint-no-decode-iterm2
branch
from
November 14, 2022 21:32
3e49113 to
709af80
Compare
Robert Estelle (rwe)
force-pushed
the
shellint-no-decode-iterm2
branch
from
November 15, 2022 23:16
709af80 to
78b1361
Compare
Daniel Imms (Tyriar)
approved these changes
Nov 23, 2022
Daniel Imms (Tyriar)
left a comment
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Robert Estelle (@rwe)
Daniel Imms (Tyriar)
enabled auto-merge
November 23, 2022 17:31
Daniel Imms (Tyriar)
disabled auto-merge
November 23, 2022 17:31
Connor Peet (connor4312)
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike
VSCodeOscPt.Property, the iTerm2 OSC sequences do not support backslash or hex-escape sequences. Interpretation of those messages should not attempt evaluation of those escapes.See: https://github.com/gnachman/iTerm2/blob/bb0882332cec5196e4de4a4225978d746e935279/sources/VT100Terminal.m#L2089-L2105