Editor state change, break after match - #166283
Merged
Merged
Conversation
In State.update, the update type was compared against all the possible types. The solution is to use a switch case instead, or to use else-if instead.
Contributor
Author
|
@microsoft-github-policy-service agree |
VS Code Bot (vscodenpa)
added
the
install-update
Contributor
|
What issue does this fix? |
Benjamin Pasero (bpasero)
added
info-needed
Contributor
Author
|
It does not fix any issues. It simply saves a few comparisons on every single selection change. Which might save a few microseconds. |
Benjamin Pasero (bpasero)
removed
the
info-needed
Contributor
|
Yeah thanks, your solution makes a lot more sense to me, weird that we did not use |
Benjamin Pasero (bpasero)
enabled auto-merge (squash)
November 15, 2022 06:02
Benjamin Pasero (bpasero)
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In State.update, the update type was compared against all the possible types.
The solution is to use a switch case instead, or to use else-if instead.