shared-libuv still requires deps/uv/uv.gyp

[kapouer]

Version

Any recent version

Platform

Linux Debian

Subsystem

build

What steps will reproduce the bug?

Build with that flag
--shared-libuv
but without
deps/uv/*

How often does it reproduce? Is there a required condition?

n/a

What is the expected behavior? Why is that the expected behavior?

Without deps/uv/* and with --shared-libuv, it should build.

What do you see instead?

make[1]: *** No rule to make target 'deps/uv/uv.gyp', needed by 'out/Makefile'. Stop.

Additional information

It's not something really bad.
It would be nice if using shared-libuv, shared-zlib, shared-llhttp, didn't require the presence of gyp files.

[richardlau]

@kapouer I think #55789 would fix this.

[kapouer]

Yep ! If that works, that works.

[github-actions]

This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[github-actions]

This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.