meta: remove legacy website code - #6362
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d734d0d to
b022ba1
Compare
|
Lighthouse Results
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
I think we can remove all the .hbs in markown files (the key metadata layout) which are clearly legacy
Not necessary for this PR, but we can do as a follow-up :) |
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGTM !! Greeeattt we finally see what we've done
Just here all i18n key can be remove (because you remove the component) I checked by hand using VScode's search tool
components.header.buttons.toggleLanguagecomponents.home.xlayouts.blogIndex.categoryNamelayouts.blogPost.author.byLine
On a follow-up PR xD |
this looks fine, and i dont want any changes, but to be fair, I use "NVM for Windows" |
Right, it's just that NVM for Windows is not NVM and we want to avoid creating confusion. |
|
What's the plan for deploying this? Much as deploying on a Friday is generally a bad thing, part of me thinks it might be beneficial here to let this bake in production over the weekend with more hobbyist developer traffic, before the working week? |
I've made a https://beta-node-js-org.vercel.app/en and shared the link on Twitter. I believe we want to release this after a few feedbacks are in. We also want to write a blog post first (possibly) and get some things ready for launch. |
|
cc @nodejs/nodejs-website @nodejs/web-infra I've made a new branch called "legacy" which is a stale copy of current latest commit of "main" and I've pointed Vercel to use "legacy" for production builds. This allows us to merge this PR as it is now without accidentally releasing the website redesign on https://nodejs.org, and will enable us to keep the legacy website on maintenance mode (hot-fixes and bug-fixes on the "legacy" branch until we get the redesign released). So, I'm merging this PR as it is, so we can adequately iterate feedback. |
This PR removes the Legacy Website from the Codebase and automatically enables the Node.js Website Redesign (as the feature flag is unnecessary)
We can revert this anytime if we see issues or revert the Vercel deployment (without a Git revert).
Note that this is an initial cutover, and there might be more unused files, functions, and utilities that I might have missed, which can be cleaned up subsequently.
Also, legacy translations must be removed manually before we can enable Crowdin!
THIS PR EFFECTIVELY ENABLES THE WEBSITE REDESIGN
Do not merge this PR!
cc @nodejs/nodejs-website @nodejs/web-infra
And I'm so freaking excited!