Skip to content

meta: remove legacy website code - #6362

Merged
ovflowd merged 12 commits into
mainfrom
meta/remove-legacy-website-code
Mar 2, 2024
Merged

ovflowd merged 12 commits into
mainfrom
meta/remove-legacy-website-code

Conversation

@ovflowd

@ovflowd ovflowd commented Feb 28, 2024 •

Copy link
Copy Markdown
Member

This PR removes the Legacy Website from the Codebase and automatically enables the Node.js Website Redesign (as the feature flag is unnecessary)

We can revert this anytime if we see issues or revert the Vercel deployment (without a Git revert).

Note that this is an initial cutover, and there might be more unused files, functions, and utilities that I might have missed, which can be cleaned up subsequently.

Also, legacy translations must be removed manually before we can enable Crowdin!

THIS PR EFFECTIVELY ENABLES THE WEBSITE REDESIGN

Do not merge this PR!

cc @nodejs/nodejs-website @nodejs/web-infra

And I'm so freaking excited!

@ovflowd ovflowd added website redesign Issue/PR part of the Node.js Website Redesign infrastructure Issues/PRs related to the Repository Infra labels Feb 28, 2024
@ovflowd
ovflowd requested review from a team as code owners February 28, 2024 19:03
@vercel

vercel Bot commented Feb 28, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 11:58pm

Comment thread app/[locale]/layout.tsx Outdated
Comment thread .unimportedrc.json Outdated
@github-actions

github-actions Bot commented Feb 28, 2024 •

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 97 🟢 98 🟢 92 🟢 91 🔗
/en/about 🟢 100 🟢 98 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟠 83 🟢 92 🔗

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove all the .hbs in markown files (the key metadata layout) which are clearly legacy

Comment thread next.constants.mjs Outdated
@github-actions

github-actions Bot commented Feb 28, 2024 •

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.839s ⏱️

@ovflowd

ovflowd commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

I think we can remove all the .hbs in markown files (the key metadata layout) which are clearly legacy

Not necessary for this PR, but we can do as a follow-up :)

@MattIPv4 MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Greeeattt we finally see what we've done

Just here all i18n key can be remove (because you remove the component) I checked by hand using VScode's search tool

  • components.header.buttons.toggleLanguage
  • components.home.x
  • layouts.blogIndex.categoryName
  • layouts.blogPost.author.byLine

@ovflowd

ovflowd commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

LGTM !! Greeeattt we finally see what we've done

Just here all i18n key can be remove (because you remove the component) I checked by hand using VScode's search tool

  • components.header.buttons.toggleLanguage
  • components.home.x
  • layouts.blogIndex.categoryName
  • layouts.blogPost.author.byLine

On a follow-up PR xD

@bmuenzenmeyer

Copy link
Copy Markdown
Contributor

For Windows, we're recommending "Chocolatey". @nodejs/nodejs-website if y'all could re-review :)

this looks fine, and i dont want any changes, but to be fair, I use "NVM for Windows"

@ovflowd

ovflowd commented Mar 1, 2024

Copy link
Copy Markdown
Member Author

For Windows, we're recommending "Chocolatey". @nodejs/nodejs-website if y'all could re-review :)

this looks fine, and i dont want any changes, but to be fair, I use "NVM for Windows"

Right, it's just that NVM for Windows is not NVM and we want to avoid creating confusion.

@MattIPv4

MattIPv4 commented Mar 1, 2024

Copy link
Copy Markdown
Member

What's the plan for deploying this? Much as deploying on a Friday is generally a bad thing, part of me thinks it might be beneficial here to let this bake in production over the weekend with more hobbyist developer traffic, before the working week?

@ovflowd

ovflowd commented Mar 1, 2024

Copy link
Copy Markdown
Member Author

What's the plan for deploying this? Much as deploying on a Friday is generally a bad thing, part of me thinks it might be beneficial here to let this bake in production over the weekend with more hobbyist developer traffic, before the working week?

I've made a https://beta-node-js-org.vercel.app/en and shared the link on Twitter. I believe we want to release this after a few feedbacks are in. We also want to write a blog post first (possibly) and get some things ready for launch.

@ovflowd

ovflowd commented Mar 2, 2024

Copy link
Copy Markdown
Member Author

cc @nodejs/nodejs-website @nodejs/web-infra

I've made a new branch called "legacy" which is a stale copy of current latest commit of "main" and I've pointed Vercel to use "legacy" for production builds.

This allows us to merge this PR as it is now without accidentally releasing the website redesign on https://nodejs.org, and will enable us to keep the legacy website on maintenance mode (hot-fixes and bug-fixes on the "legacy" branch until we get the redesign released).

So, I'm merging this PR as it is, so we can adequately iterate feedback.

@ovflowd
ovflowd merged commit 079dacb into main Mar 2, 2024
@ovflowd
ovflowd deleted the meta/remove-legacy-website-code branch March 2, 2024 00:53

This branch was successfully deployed

2 active deployments
Storybook — ad1709fe Deployed Mar 2, 2024 by ovflowd
Preview — ad1709fe Deployed Mar 1, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues/PRs related to the Repository Infra website redesign Issue/PR part of the Node.js Website Redesign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants