Skip to content

feat: add configurable timeout for Presto to querybook - #1207

Merged
czgu merged 3 commits into
pinterest:masterfrom
czgu:presto
Mar 31, 2023
Merged

feat: add configurable timeout for Presto to querybook#1207
czgu merged 3 commits into
pinterest:masterfrom
czgu:presto

Conversation

@czgu

@czgu czgu commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator
  • added force terminate when cancelling queries
  • added timeout config for presto
  • make sure numberfield always return a number

Comment thread querybook/server/lib/query_executor/clients/presto.py Outdated
@czgu
czgu merged commit 4e234d6 into pinterest:master Mar 31, 2023
@czgu
czgu deleted the presto branch March 31, 2023 22:10
@czgu czgu changed the title feat: add configurable timeout to querybook feat: add configurable timeout for Presto to querybook Mar 31, 2023
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
* feat: add configurable timeout to querybook

* remove print

* remove unless comment
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
* feat: add configurable timeout to querybook

* remove print

* remove unless comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants