Skip to content

fix: cast table max upload size to int - #1374

Merged
czgu merged 1 commit into
pinterest:masterfrom
rchandnaeg:external/table-max-upload-size-int
Nov 21, 2023
Merged

fix: cast table max upload size to int#1374
czgu merged 1 commit into
pinterest:masterfrom
rchandnaeg:external/table-max-upload-size-int

Conversation

@rchandnaeg

Copy link
Copy Markdown
Contributor

Environment variables are loaded in as strings, which results in the following error for loading QuerybookSettings.TABLE_MAX_UPLOAD_SIZE

querybook_web            | Traceback (most recent call last):
querybook_web            |   File "/opt/querybook/querybook/server/app/datasource.py", line 84, in handler
querybook_web            |     results = fn(**kwargs)
querybook_web            |   File "/opt/querybook/querybook/server/datasources/event_log.py", line 18, in log_frontend_event
querybook_web            |     events = json.loads(flask.request.data)

This fix casts the table max upload size variable to an int before applying it to the flask app config

@czgu
czgu merged commit e2efe8e into pinterest:master Nov 21, 2023
@czgu

czgu commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

thank you!

aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@rchandnaeg
rchandnaeg deleted the external/table-max-upload-size-int branch February 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants