Skip to content

chore: Update pip install command - #1407

Merged
czgu merged 1 commit into
pinterest:masterfrom
baumandm:external/pip-install
Feb 5, 2024
Merged

chore: Update pip install command#1407
czgu merged 1 commit into
pinterest:masterfrom
baumandm:external/pip-install

Conversation

@baumandm

@baumandm baumandm commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Previously, the pip install command in the Dockerfile ended in || true, so it never failed. I think the purpose was to make local.txt optional, but it also covers up any errors installing packages.

This removes || true and instead makes local.txt optional by checking to see if the file exists.

@czgu czgu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@czgu
czgu merged commit 97d3473 into pinterest:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants