Skip to content

Remove dead code / unused references - #370

Merged
meowcodes merged 2 commits into
masterfrom
removegraph
Jan 13, 2021
Merged

Remove dead code / unused references#370
meowcodes merged 2 commits into
masterfrom
removegraph

Conversation

@czgu

@czgu czgu commented Jan 7, 2021

Copy link
Copy Markdown
Collaborator

Removed unused exports via

ts-prune -i stories | grep -v "used in module"

which removes storybook and exports used internally

There are a few components that were removed, one worth mentioning is that SingleCRUD is now GenericCRUD and the old GenericCRUD is removed.

The remaining exports are

datahub/webapp/const/chartColors.ts:76 - accentColor
datahub/webapp/hooks/useForceUpdate.ts:3 - useForceUpdate
datahub/webapp/lib/dataHubUI.ts:11 - sendAlert
datahub/webapp/redux/dataDoc/action.ts:492 - getDataDocEditors
datahub/webapp/redux/queryView/action.ts:151 - updateOrderBy
datahub/webapp/redux/search/action.ts:83 - resetSearch
datahub/webapp/redux/search/types.ts:12 - DisplayOption

which I skipped waiting to see if they would be used in the future.

also turned on

        "noUnusedLocals": true,
        "noUnusedParameters": true,

to remove any unused imports

@czgu
czgu requested a review from meowcodes January 7, 2021 20:48
@meowcodes
meowcodes merged commit 616fb6d into master Jan 13, 2021
@meowcodes
meowcodes deleted the removegraph branch January 13, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants