Allow for regular comments to be part of the AST and pretty-printed - #154687
Draft
FranciscoTGouveia wants to merge 1 commit into
Draft
FranciscoTGouveia wants to merge 1 commit into
FranciscoTGouveia wants to merge 1 commit into
Conversation
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
FranciscoTGouveia
force-pushed
the
parse-regular-comments
branch
from
April 1, 2026 17:22
2010873 to
95a1905
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…try> Allow for regular comments to be part of the AST and pretty-printed
rustbot
added
the
S-waiting-on-perf
Contributor
|
💔 Test for 40b8708 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
FranciscoTGouveia
force-pushed
the
parse-regular-comments
branch
from
April 2, 2026 09:39
95a1905 to
64621da
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
@bors delegate=try |
Contributor
|
✌️ @FranciscoTGouveia, you can now perform try builds on this pull request! You can now post |
FranciscoTGouveia
force-pushed
the
parse-regular-comments
branch
from
April 2, 2026 13:50
64621da to
3d03995
Compare
This comment has been minimized.
This comment has been minimized.
FranciscoTGouveia
force-pushed
the
parse-regular-comments
branch
2 times, most recently
from
April 2, 2026 15:48
d747b96 to
ffd82d5
Compare
This comment has been minimized.
This comment has been minimized.
This commit is merely a test to check if, and by how much, this patch incurs in performance regressions.
FranciscoTGouveia
force-pushed
the
parse-regular-comments
branch
from
April 4, 2026 08:10
ffd82d5 to
024685e
Compare
Contributor
|
☔ The latest upstream changes (presumably #154958) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
☔ The latest upstream changes (presumably #156023) made this pull request unmergeable. Please resolve the merge conflicts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is merely a test to check if, and by how much, this patch incurs performance regressions.
CC @Kobzol