Test panics and wasm32-wasip3 in CI, not wasip1 - #163132
Open
alexcrichton wants to merge 1 commit into
Open
alexcrichton wants to merge 1 commit into
alexcrichton wants to merge 1 commit into
Conversation
Collaborator
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update The run-make-support library was changed cc @jieyouxu
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-CI
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Urgau
reviewed
Sep 21, 2026
| ENV NO_OVERFLOW_CHECKS=1 | ||
|
|
||
| RUN curl -L https://github.com/bytecodealliance/wasmtime/releases/download/v44.0.1/wasmtime-v44.0.1-x86_64-linux.tar.xz | \ | ||
| RUN curl -L https://github.com/bytecodealliance/wasmtime/releases/download/v48.0.2/wasmtime-v48.0.2-x86_64-linux.tar.xz | \ |
Member
There was a problem hiding this comment.
Small drive-by but should probably use our own ci-mirrors.
Member
Author
There was a problem hiding this comment.
Sent as rust-lang/ci-mirrors#57 and I'll update here once that's merged
bjorn3
reviewed
Sep 22, 2026
Member
|
@rustbot reroll |
alexcrichton
added a commit
to alexcrichton/ci-mirrors
that referenced
this pull request
Sep 22, 2026
* Add wasmtime 48.0.2 * Add wasi-sdk-34 Requested on rust-lang/rust#163132
alexcrichton
force-pushed
the
wasm-unwind-tests
branch
from
September 22, 2026 14:48
f27e206 to
ffe8294
Compare
This comment has been minimized.
This comment has been minimized.
alexcrichton
force-pushed
the
wasm-unwind-tests
branch
from
September 22, 2026 17:52
ffe8294 to
bd200d1
Compare
This comment has been minimized.
This comment has been minimized.
This commit migrates the `test-various` job in CI from testing the `wasm32-wasip1` target to testing the `wasm32-wasip3` target. While doing so this additionally runs tests with `-Cpanic=unwind` instead of the historical `-Cpanic=abort` to expand the scope of tests slightly and run `alloc` tests, for example. The purpose of this change is to start migrating towards a wasm testing target which has a more fully-featured `std`, e.g. panics & threads, to run more tests in CI and make it less of a too-different target. This change was originally proposed at rust-lang/compiler-team/1039 which contains some more background details as well. The major notable change in test coverage here is running tests with `-Cpanic=unwind`. WebAssembly targets by default still use `-Cpanic=abort` and this means that large swaths of the test suite do not execute because they require panicking/unwinding in one way or another. CI here is configuring wasm targets to specifically enable unwinding, but only for the testing build. To achieve this a new `bootstrap.toml` option is added which enables configuring the default `panic_strategy` for wasm targets -- an option only intended to be used in testing. Most of this change is adjusting tests for this new testing infrastructure, some old Wasmtime-related TODOs are cleaned up as well with an updated build. Notably the `only-wasm32-wasip1` directive for compiletest is removed and all preexisting tests are migrated to run for any wasm target. The `run-make` suite in particular is updated to handle when the wasm target outputs components and the various ABI details of the wasip3 target. This change notably does not yet start to run `std`'s test suite for the `wasm32-wasip3` target. Too much of that test suite requires threads to be useful to run at this time, and as such running those tests is delayed until a later time when cooperative threading is enabled.
alexcrichton
force-pushed
the
wasm-unwind-tests
branch
from
September 22, 2026 20:38
bd200d1 to
46456eb
Compare
Member
Author
|
@bors try jobs=test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 22, 2026
Test panics and wasm32-wasip3 in CI, not wasip1 try-job: test-various
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit migrates the
test-variousjob in CI from testing thewasm32-wasip1target to testing thewasm32-wasip3target. While doing so this additionally runs tests with-Cpanic=unwindinstead of the historical-Cpanic=abortto expand the scope of tests slightly and runalloctests, for example. The purpose of this change is to start migrating towards a wasm testing target which has a more fully-featuredstd, e.g. panics & threads, to run more tests in CI and make it less of a too-different target. This change was originally proposed at rust-lang/compiler-team#1039 which contains some more background details as well.The major notable change in test coverage here is running tests with
-Cpanic=unwind. WebAssembly targets by default still use-Cpanic=abortand this means that large swaths of the test suite do not execute because they require panicking/unwinding in one way or another. CI here is configuring wasm targets to specifically enable unwinding, but only for the testing build. To achieve this a newbootstrap.tomloption is added which enables configuring the defaultpanic_strategyfor wasm targets -- an option only intended to be used in testing.Most of this change is adjusting tests for this new testing infrastructure, some old Wasmtime-related TODOs are cleaned up as well with an updated build. Notably the
only-wasm32-wasip1directive for compiletest is removed and all preexisting tests are migrated to run for any wasm target. Therun-makesuite in particular is updated to handle when the wasm target outputs components and the various ABI details of the wasip3 target.This change notably does not yet start to run
std's test suite for thewasm32-wasip3target. Too much of that test suite requires threads to be useful to run at this time, and as such running those tests is delayed until a later time when cooperative threading is enabled.