Skip to content

Module ns 2 - #3751

Closed
pcwalton wants to merge 2 commits into
rust-lang:incomingfrom
pcwalton:module-ns-2
Closed

pcwalton wants to merge 2 commits into
rust-lang:incomingfrom
pcwalton:module-ns-2

Conversation

@pcwalton

Copy link
Copy Markdown
Contributor

r? @brson

@brson

brson commented Oct 13, 2012

Copy link
Copy Markdown
Contributor

r+

@pcwalton pcwalton closed this Oct 16, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Jul 29, 2024
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
3666: Reload part of the server configuration without restarts r=matklad a=SomeoneToIgnore

Partially addresses rust-lang/rust-analyzer#2857

Closes rust-lang#3751

Reloads all server configuration that's not related to VFS without restarts.

The VFS-related parameters are not considered, since VFS is planned to be rewritten/replaced in the future and I have a suspicion that with the current code, swapping the VFS and the file watchers on the fly will cause big troubles.

I have to store and process the config request id separately, since the `workspace/configuration` response returns `any[]` (https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_configuration), if there's a better way to handle those responses, let me know.



Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants