Run branch cleanup after copy prop - #59290
Merged
Merged
Conversation
commented
Mar 19, 2019
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
davidtwco
approved these changes
Mar 19, 2019
commented
Mar 19, 2019
Member
|
r? @davidtwco |
commented
Mar 19, 2019
Contributor
|
@bors r=davidtwco rollup |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
Member
|
14 seconds too late. |
This comment has been minimized.
This comment has been minimized.
commented
Mar 19, 2019
Collaborator
|
📌 Commit ab41023 has been approved by |
commented
Mar 19, 2019
Contributor
|
Is running this pass expected to have any (negative) effect on compilation times? |
commented
Mar 19, 2019
Contributor
Author
|
We've been running it after "const propagation" (a pass that just lints and does not actually propagate anything) already. This is just a second run after copy prop (which is semi-expensive). The pass itself is very cheap (it just iterates over all the blocks' terminators and checks for constants, there's no larger analysis going on). I think we'd rather end up seing build time improvements since more code is thrown away before llvm ever sees it. |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preliminary work for #59288 (comment) which gets rid of
ifin the HIR.cc @rust-lang/wg-mir-opt @Centril