Skip to content

V25.2.0-IOFreeze: new Availability Schedule Name fields for coils - #5498

Merged
jmarrec merged 15 commits into
developfrom
v25.2.0-IOFreeze-coil-avail
Oct 22, 2025
Merged

V25.2.0-IOFreeze: new Availability Schedule Name fields for coils#5498
jmarrec merged 15 commits into
developfrom
v25.2.0-IOFreeze-coil-avail

Conversation

@joseph-robertson

Copy link
Copy Markdown
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Oct 10, 2025
@joseph-robertson joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Oct 10, 2025
@joseph-robertson joseph-robertson mentioned this pull request Oct 10, 2025
26 tasks
@ci-commercialbuildings

ci-commercialbuildings commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

CI Results for a33ed50:

@joseph-robertson
joseph-robertson marked this pull request as ready for review October 16, 2025 22:28
Base automatically changed from v25.2.0-IOFreeze to develop October 20, 2025 12:08
@jmarrec
jmarrec force-pushed the v25.2.0-IOFreeze-coil-avail branch from a33ed50 to af74ada Compare October 22, 2025 08:51

@jmarrec jmarrec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

A3, \field Indoor Air Inlet Node Name
A3, \field Availability Schedule Name
\note Availability schedule name for this system. Schedule value > 0 means the system is available.
\note If this field is blank, the system is always available.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess this note could have been removed since it's required field)

@jmarrec
jmarrec merged commit a715b9e into develop Oct 22, 2025
2 of 4 checks passed
@jmarrec
jmarrec deleted the v25.2.0-IOFreeze-coil-avail branch October 22, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants