Remove temp backcompat code. - #4633
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes temporary backward-compatibility handling in BrokerHttpClient.GetRunnerMessageAsync, relying on the broker’s structured error responses rather than a legacy 403 Forbidden fallback.
Changes:
- Removed the special-case
HttpStatusCode.Forbiddenhandling that threw anAccessDeniedExceptionwith a deprecation message. - Kept structured error-body parsing to map
BrokerErrorKind.RunnerVersionTooOldtoAccessDeniedExceptionwithErrorCode = 1.
Show a summary per file
| File | Description |
|---|---|
| src/Sdk/WebApi/WebApi/BrokerHttpClient.cs | Removes legacy 403 back-compat exception path for runner message retrieval. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
salmanmkc
approved these changes
Aug 14, 2026
luketomlinson
approved these changes
Aug 14, 2026
Reinaldotec
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/actions-runtime/issues/5611