Limits for available CPU cores during importing - #97
Merged
Conversation
Also added tests for new functions used
joelillo
requested changes
Apr 1, 2026
joelillo
left a comment
joelillo
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Just one small cleanup comment
| // Get the amount of logical cores available without the program interrupting other system processes. | ||
| // At the time of writing the recommended minimal cpu count is 3 so for systems with less let all be available. | ||
| func GetAvailableCores(coresNum int) int { | ||
| if coresNum > 2 { |
Contributor
There was a problem hiding this comment.
Slightly cleaner logic for this nested block:
if coresNum == 3 {
coresNum--
} else if coresNum > 3 {
coresNum -= 2
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following limits for logical CPU cores usage during importing:
Also added tests for new functions.