Skip to content

Fix length validation for palette in the stage library bindings - #10904

Merged
dhalbert merged 1 commit into
adafruit:mainfrom
python-ugame:stage_validate_length
Mar 30, 2026
Merged

Fix length validation for palette in the stage library bindings#10904
dhalbert merged 1 commit into
adafruit:mainfrom
python-ugame:stage_validate_length

Conversation

@deshipu

@deshipu deshipu commented Mar 30, 2026

Copy link
Copy Markdown

Right now it's impossible to use the Stage library, because it always throws a validation error.

Right now it's impossible to use the Stage library, because it always
throws a validation error.
@dhalbert

Copy link
Copy Markdown
Collaborator

This is against main, but my understanding is that it's also broken in 10.1.x. Should it be backported to that, or the base changed on this PR?

There aren't any other 10.1.x changes pending right now.

@deshipu

deshipu commented Mar 30, 2026

Copy link
Copy Markdown
Author

It would be great if it could be backported. I'm not entirely familiar withe the process, so I don't know what is the difference.

@dhalbert

Copy link
Copy Markdown
Collaborator

If you made a PR against 10.1.x instead of main, then it would go into the next 10.1.x release, and we'd also forward-port it to main, just by merging 10.1.x into main.

It's possible to change the base for the PR by clicking Edit on the title, but that often doesn't work if there are other changes.

@deshipu
deshipu changed the base branch from main to 10.1.x March 30, 2026 16:19
@deshipu

deshipu commented Mar 30, 2026

Copy link
Copy Markdown
Author

I changed the base, it seems to have worked.

@dhalbert
dhalbert changed the base branch from 10.1.x to main March 30, 2026 16:28
@dhalbert

dhalbert commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

Changing the base brought in all the changes to main (>300 changed files), so that didn't work. I changed it back. You could make a new PR using a new branch off of 10.1.x, or we can just merge this and then cherry-pick the change from this PR into another PR against 10.1.x.

@deshipu

deshipu commented Mar 30, 2026

Copy link
Copy Markdown
Author

I made a second pull request against 10.1.x here: #10909

I wouldn't mind if both of them were merged, so I'm not closing this one.

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@dhalbert
dhalbert merged commit 304a9a8 into adafruit:main Mar 30, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants