Fix uses of PICO_RP2040 and PICO_RP2350 - #11014
Merged
Merged
Conversation
tannewt
approved these changes
May 19, 2026
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Let's try to upstream these changes for PIO USB too.
Collaborator
Author
I made an identical PR to https://github.com/sekigon-gonnoc/Pico-PIO-USB.git and EDIT: I was wrong. Thach review it and sekigon-gonnoc merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code taken from https://github.com/eightycc/circuitpython/tree/fix-defines.
PICO_RP2040andPICO_RP2350properly for all builds, as0or1.#ifinstead of the incorrect#ifdeffor these cpp macros.Pico-PIO-USBthat also corrects the use of the macro.