Skip to content

ports/espressif/common-hal/socketpool/SocketPool.c: remove old workaround for lwip issue - #11016

Merged
tannewt merged 1 commit into
adafruit:mainfrom
dhalbert:remove-lwip-workaround
May 19, 2026
Merged

ports/espressif/common-hal/socketpool/SocketPool.c: remove old workaround for lwip issue#11016
tannewt merged 1 commit into
adafruit:mainfrom
dhalbert:remove-lwip-workaround

Conversation

@dhalbert

@dhalbert dhalbert commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Remove some code that removed trailing dots from hostnames to compensate for an lwip issue. This was fixed long ago.

Tested on a Metro ESP32-S3 with:

import wifi, socketpool

pool = socketpool.SocketPool(wifi.radio)
print(pool.getaddrinfo("adafruit.com.", 80))

@dhalbert
dhalbert requested a review from tannewt May 19, 2026 19:11
@dhalbert
dhalbert force-pushed the remove-lwip-workaround branch from 2402aed to b2fdd17 Compare May 19, 2026 19:14
tannewt
tannewt approved these changes May 19, 2026
View reviewed changes

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt
tannewt merged commit 084314b into adafruit:main May 19, 2026
258 checks passed
@dhalbert
dhalbert deleted the remove-lwip-workaround branch May 20, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove workaround for fixed idf bug

2 participants

@dhalbert @tannewt