Fix multi-threading for OSX - #37
Merged
Merged
Conversation
Fixes bug #36. I think the issue is the original method "shares" the shell that is used by all the workers and therefore blocking other calls to that shell. Using subprocess.call with the shell=true is pretty much allowing each worker to spawn their own instance of a shell.
Update task runner to allow multi-threading on OSX
codingo
approved these changes
Apr 30, 2019
Owner
|
Closes #36 |
Owner
|
Tested and working as expected. Thank-you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue was with how OSX handles os.system( ) calls. (I believe it's like they were trying to share the same shell, so they would therefore naturally block future calls making it synchronous)
Switched to subprocess.call( ) and allowing each worker to spawn their own instance of a shell.