Skip to content

Grpc-based remoteDb - #788

Merged
AskAlexSharov merged 22 commits into
masterfrom
grpc
Jul 27, 2020
Merged

Grpc-based remoteDb#788
AskAlexSharov merged 22 commits into
masterfrom
grpc

Conversation

@AskAlexSharov

@AskAlexSharov AskAlexSharov commented Jul 25, 2020

Copy link
Copy Markdown
Collaborator
  • Only 1 method left in kv.proto.
  • Reopen tx every minute, but no protection against slow client (don't see easy way to implement).

Other changes:

  • Renamed some cli flags to follow Geth style: --http.port
  • Renamed --remote-db-addr to --private.api.addr - because GRC can serve more than 1 service on same port (probably we will add more private apis later)

Comment thread ethdb/kv_remote2.go Outdated
@AlexeyAkhunov

Copy link
Copy Markdown
Contributor

I think it can be useful not to expose transactions to the client at all, and yes, inconsistent data can be detected on the client side

@AskAlexSharov
AskAlexSharov force-pushed the grpc branch 7 times, most recently from 908653a to ca3bf01 Compare July 27, 2020 04:33
@AskAlexSharov AskAlexSharov changed the title [to discuss] Grpc-based remoteDb Grpc-based remoteDb Jul 27, 2020
@AskAlexSharov
AskAlexSharov force-pushed the grpc branch 5 times, most recently from aecd1c5 to 0c3a36a Compare July 27, 2020 11:10
@AskAlexSharov
AskAlexSharov merged commit c4a1ffa into master Jul 27, 2020
@AlexeyAkhunov
AlexeyAkhunov deleted the grpc branch September 29, 2020 15:10
cffls pushed a commit to cffls/erigon that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants