Update ROCM version to 7.1 from 6.3 - #8867
Conversation
- Update PyTorch to 2.10.0+rocm7.1 (from 2.7.1+rocm6.3) - Update TorchVision to 0.25.0+rocm7.1 (from 0.22.1+rocm6.3) - Update PyTorch ROCm index URL to rocm7.1 - Update Docker ROCm runtime to 7.1.1 (from 6.3.4) ROCm 7.1 adds support for 3 new GPU architectures: - gfx950: CDNA3+ (Instinct MI350, MI325X) - gfx1150: RDNA 3.5 (Strix Point APU) - gfx1151: RDNA 3.5 (Strix Halo APU) All 11 previously supported architectures remain compatible. Total supported architectures: 14 (11 existing + 3 new) Relates to invoke-ai#8655
The uv package manager couldn't resolve triton-rocm as a transitive dependency of torch from the PyTorch custom index. This commit adds triton-rocm==3.6.0 explicitly to the rocm extras with a Linux-only platform marker. Changes: - Added triton-rocm==3.6.0; sys_platform == 'linux' to rocm extras - Added triton-rocm source configuration pointing to torch-rocm index - Already committed: torch version constraint relaxation (>=2.7.0,<3.0) - Already committed: platform environment restrictions for ROCm Verified with uv sync --extra rocm: - torch==2.10.0+rocm7.1 installed correctly - torchvision==0.25.0+rocm7.1 installed correctly - triton-rocm==3.6.0 resolved successfully - ROCm 7.1.25424 detected on AMD Radeon PRO V620 - All 8 model architectures accessible - GPU compute operations verified Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Changed torch backend from rocm6.3 to rocm7.1 in manual installation instructions for Invoke v5.12 and later. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Had a guy test rocm 7.2, he wasn't having an easy time getting this particular PR working due to an unrelated technical issue, however invoke DOES work with a simple rocm update. The speeds were not good, but it does work, we can address rocm speed at a later date probably. |
|
Fix the merge conflict and I'll approve |
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
@joshistoast my code should not have caused these failure AFAIK. Wonder if there is a pinning that isn't resolving the same for MPS and for typegen as I regen the uv.lock? Asking before I spend time deep diving if it's an obvious fix to you. Typo* |
|
@heathen711 I’d like to get this ROCM update rolled into the 6.13.5 release. Your PR is currently failing several checks and has some easily-fixed conflicts with |
|
Apologies, I was on vacation all of last week. I see your fork, closing this. |
* Upgrade ROCm support from 6.3 to 7.1 - Update PyTorch to 2.10.0+rocm7.1 (from 2.7.1+rocm6.3) - Update TorchVision to 0.25.0+rocm7.1 (from 0.22.1+rocm6.3) - Update PyTorch ROCm index URL to rocm7.1 - Update Docker ROCm runtime to 7.1.1 (from 6.3.4) ROCm 7.1 adds support for 3 new GPU architectures: - gfx950: CDNA3+ (Instinct MI350, MI325X) - gfx1150: RDNA 3.5 (Strix Point APU) - gfx1151: RDNA 3.5 (Strix Halo APU) All 11 previously supported architectures remain compatible. Total supported architectures: 14 (11 existing + 3 new) Relates to #8655 * Fix uv sync for ROCm 7.1 by explicitly declaring triton-rocm The uv package manager couldn't resolve triton-rocm as a transitive dependency of torch from the PyTorch custom index. This commit adds triton-rocm==3.6.0 explicitly to the rocm extras with a Linux-only platform marker. Changes: - Added triton-rocm==3.6.0; sys_platform == 'linux' to rocm extras - Added triton-rocm source configuration pointing to torch-rocm index - Already committed: torch version constraint relaxation (>=2.7.0,<3.0) - Already committed: platform environment restrictions for ROCm Verified with uv sync --extra rocm: - torch==2.10.0+rocm7.1 installed correctly - torchvision==0.25.0+rocm7.1 installed correctly - triton-rocm==3.6.0 resolved successfully - ROCm 7.1.25424 detected on AMD Radeon PRO V620 - All 8 model architectures accessible - GPU compute operations verified Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Update uv lock and remove old dockerfile * docs: update ROCm torch backend from 6.3 to 7.1 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> * fix: regenerate uv.lock with ROCm 7.1 dependencies Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> * remove redundant inclusion of torch-triton wheel && confirm no aarch64-linux support * chore(frontend): openapi and typegen * chore: drop spurious typegen changes from ROCm PR The ROCm 7.1 update is dependency-only and does not alter any backend route or model, so schema.ts/openapi.json should match main. The earlier regeneration introduced spurious diffs (removed @example blocks, reformatted JSDoc) from a local tooling/backend mismatch, failing the typegen-checks "compare files" step. Restore both files to main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(deps): keep macOS on torch 2.7.x; gate rocm extra to linux Loosening the base torch pin to <3.0 (so the rocm extra could use 2.10.0+rocm7.1) let macOS resolve torch 2.12.0, whose MPS backend fails with OOM on GitHub's hosted macOS runners (no usable Metal GPU), breaking the py3.x macos-default pytest jobs. Split the base pin by platform so macOS stays on 2.7.x (matching main) while linux/win still allow >=2.10, and gate the rocm extra's torch/torchvision to sys_platform == 'linux' (ROCm is x86_64-linux-only) so non-linux resolution is unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(frontend): regenerate schema for pydantic 2.13 docstring descriptions The dependency update bumps pydantic 2.11.7 -> 2.13.4, which now emits a plain class docstring as the JSON-schema description. CacheStats gains "Collect statistics on cache performance." in both openapi.json and schema.ts. This is the sole schema delta from the bump and is what the openapi-checks/typegen-checks jobs regenerate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Heathen711 <Heathen711@me.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: heathen711 <heathen711@example.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
* Upgrade ROCm support from 6.3 to 7.1 - Update PyTorch to 2.10.0+rocm7.1 (from 2.7.1+rocm6.3) - Update TorchVision to 0.25.0+rocm7.1 (from 0.22.1+rocm6.3) - Update PyTorch ROCm index URL to rocm7.1 - Update Docker ROCm runtime to 7.1.1 (from 6.3.4) ROCm 7.1 adds support for 3 new GPU architectures: - gfx950: CDNA3+ (Instinct MI350, MI325X) - gfx1150: RDNA 3.5 (Strix Point APU) - gfx1151: RDNA 3.5 (Strix Halo APU) All 11 previously supported architectures remain compatible. Total supported architectures: 14 (11 existing + 3 new) Relates to invoke-ai#8655 * Fix uv sync for ROCm 7.1 by explicitly declaring triton-rocm The uv package manager couldn't resolve triton-rocm as a transitive dependency of torch from the PyTorch custom index. This commit adds triton-rocm==3.6.0 explicitly to the rocm extras with a Linux-only platform marker. Changes: - Added triton-rocm==3.6.0; sys_platform == 'linux' to rocm extras - Added triton-rocm source configuration pointing to torch-rocm index - Already committed: torch version constraint relaxation (>=2.7.0,<3.0) - Already committed: platform environment restrictions for ROCm Verified with uv sync --extra rocm: - torch==2.10.0+rocm7.1 installed correctly - torchvision==0.25.0+rocm7.1 installed correctly - triton-rocm==3.6.0 resolved successfully - ROCm 7.1.25424 detected on AMD Radeon PRO V620 - All 8 model architectures accessible - GPU compute operations verified Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Update uv lock and remove old dockerfile * docs: update ROCm torch backend from 6.3 to 7.1 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> * fix: regenerate uv.lock with ROCm 7.1 dependencies Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> * remove redundant inclusion of torch-triton wheel && confirm no aarch64-linux support * chore(frontend): openapi and typegen * chore: drop spurious typegen changes from ROCm PR The ROCm 7.1 update is dependency-only and does not alter any backend route or model, so schema.ts/openapi.json should match main. The earlier regeneration introduced spurious diffs (removed @example blocks, reformatted JSDoc) from a local tooling/backend mismatch, failing the typegen-checks "compare files" step. Restore both files to main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(deps): keep macOS on torch 2.7.x; gate rocm extra to linux Loosening the base torch pin to <3.0 (so the rocm extra could use 2.10.0+rocm7.1) let macOS resolve torch 2.12.0, whose MPS backend fails with OOM on GitHub's hosted macOS runners (no usable Metal GPU), breaking the py3.x macos-default pytest jobs. Split the base pin by platform so macOS stays on 2.7.x (matching main) while linux/win still allow >=2.10, and gate the rocm extra's torch/torchvision to sys_platform == 'linux' (ROCm is x86_64-linux-only) so non-linux resolution is unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(frontend): regenerate schema for pydantic 2.13 docstring descriptions The dependency update bumps pydantic 2.11.7 -> 2.13.4, which now emits a plain class docstring as the JSON-schema description. CacheStats gains "Collect statistics on cache performance." in both openapi.json and schema.ts. This is the sole schema delta from the bump and is what the openapi-checks/typegen-checks jobs regenerate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Heathen711 <Heathen711@me.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: heathen711 <heathen711@example.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Summary
Update ROCM version to 7.1 from 6.3
Related Issues / Discussions
Part 1 of issue #8655
Resolves #9130
QA Instructions
Only affects ROCM users, just need to make sure it runs.
Checklist
Dockers build: https://github.com/heathen711/InvokeAI/actions/runs/21847900570