Skip to content

Fix/z image controlnet logging (supersedes #9289) - #9298

Merged
lstein merged 3 commits into
mainfrom
fix/z-image-controlnet-logging
Jun 24, 2026
Merged

Fix/z image controlnet logging (supersedes #9289)#9298
lstein merged 3 commits into
mainfrom
fix/z-image-controlnet-logging

Conversation

@lstein

@lstein lstein commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Reposting PR #9289 because it needed a merge and the author did not authorize write permissions by maintainer.

The original PR summary follows:

  • replace unconditional [DEBUG] / [WARNING] terminal output in z_image_controlnet_extension.py with module logger calls
  • add a regression test that checks initialization diagnostics do not write to stdout and still emit logging calls

Why

These diagnostics come from backend/library code and currently print directly to stdout, which can pollute terminal output and make log handling inconsistent for downstream callers.

Validation

  • added a regression test for constructor diagnostics behavior
  • verified the updated source and test files with py_compile
  • ran a source-level regression check to confirm the debug output is no longer implemented with direct print(...) calls

Note

The full pytest dependency set for this repository was not available in the current local environment, so I validated this change with targeted static checks plus compile-time verification.

@github-actions github-actions Bot added python PRs that change python files backend PRs that change backend files python-tests PRs that change python tests labels Jun 24, 2026
@lstein lstein changed the title Fix/z image controlnet logging Fix/z image controlnet logging (supersedes #9289) Jun 24, 2026
@Pfannkuchensack Pfannkuchensack self-assigned this Jun 24, 2026
@lstein
lstein merged commit 88b3479 into main Jun 24, 2026
17 checks passed
@lstein
lstein deleted the fix/z-image-controlnet-logging branch June 24, 2026 00:31
dunkeroni pushed a commit to dunkeroni/InvokeAI that referenced this pull request Jun 29, 2026
Co-authored-by: wunianze666-netizen <wunianze666@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend PRs that change backend files python PRs that change python files python-tests PRs that change python tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants