Fix workflow library unsupported badge - #9341
Conversation
a99a71e to
64fd6dc
Compare
Findings1. Medium -
|
|
@Pfannkuchensack Thanks! Finding 1 applies. I added failing backend tests for Finding 2 partially applies. The dead Workflow Library unsupported-badge state/JSX and unused locale description were removed, but the compatibility helper itself was not removed because it is still used by the Call Saved Workflow node picker. I wonder if the node dropdown should only show callable workflows or if showing everything is a signal that something may not be callable that the user expects to be. My concern is that querying all workflows might be burdensome. I went ahead and implemented that. |
3099ce1 to
dfec11a
Compare
Summary
Fixes Workflow Library callability messaging after Call Saved Workflow support landed. The prior work created too much output noise in the Workflow Library by surfacing negative sub-workflow compatibility state on ordinary workflows. This PR removes that negative badge from the general library view and adds a positive
Callablebadge only when a workflow can be called by another workflow (i.e. it has a Workflow Return node).Fixed callable workflow graph validation so saved optional inputs without explicit values use invocation defaults instead of being coerced to
None.Also fixed call-saved-workflow dynamic inputs to automatically resync when a selected child workflow's exposed fields change, preventing stale caller workflows from showing missing-field errors.
Related Issues / Discussions
QA Instructions
Unsupported.Callablebadge.Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)