build: remove -lrt link dependency - #2493
Closed
sam-github wants to merge 1 commit into
Closed
Conversation
It does not appear to be necessary, at least not for Node.js. See: - nodejs/node#29727
Contributor
Author
|
ci: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1588/ Any comment on this, or floating it in nodejs/node#29727? |
4 tasks
Member
|
librt is needed with old versions of glibc (< 2.17) to pull in the real-time clock definitions. Since glibc 2.12 is still the baseline for us, nine years old though it may be, that means we can't accept this PR. |
Member
|
But if you really want to get rid of librt, I'd be open to adding some kind of build flag that makes linking to it conditional. Node.js could then turn on that flag at configure time. |
cjihrig
pushed a commit
that referenced
this pull request
May 17, 2020
Using AC_CHECK_LIB ignores symbols already provided by other libraries, or in other words it links libuv against libraries that it does not need. Attempts to remove specific libraries were met with arguments that older libc versions would still require them.[0] Fix this by using AC_SEARCH_LIBS instead of AC_CHECK_LIB while using AX_PTHREAD for POSIX threads. [0] E.g. #2493 PR-URL: #2823 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
ceejatec
pushed a commit
to couchbasedeps/libuv
that referenced
this pull request
May 4, 2021
Using AC_CHECK_LIB ignores symbols already provided by other libraries, or in other words it links libuv against libraries that it does not need. Attempts to remove specific libraries were met with arguments that older libc versions would still require them.[0] Fix this by using AC_SEARCH_LIBS instead of AC_CHECK_LIB while using AX_PTHREAD for POSIX threads. [0] E.g. libuv#2493 PR-URL: libuv#2823 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
Using AC_CHECK_LIB ignores symbols already provided by other libraries, or in other words it links libuv against libraries that it does not need. Attempts to remove specific libraries were met with arguments that older libc versions would still require them.[0] Fix this by using AC_SEARCH_LIBS instead of AC_CHECK_LIB while using AX_PTHREAD for POSIX threads. [0] E.g. libuv#2493 PR-URL: libuv#2823 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
Using AC_CHECK_LIB ignores symbols already provided by other libraries, or in other words it links libuv against libraries that it does not need. Attempts to remove specific libraries were met with arguments that older libc versions would still require them.[0] Fix this by using AC_SEARCH_LIBS instead of AC_CHECK_LIB while using AX_PTHREAD for POSIX threads. [0] E.g. libuv/libuv#2493 PR-URL: libuv/libuv#2823 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
Using AC_CHECK_LIB ignores symbols already provided by other libraries, or in other words it links libuv against libraries that it does not need. Attempts to remove specific libraries were met with arguments that older libc versions would still require them.[0] Fix this by using AC_SEARCH_LIBS instead of AC_CHECK_LIB while using AX_PTHREAD for POSIX threads. [0] E.g. libuv/libuv#2493 PR-URL: libuv/libuv#2823 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does not appear to be necessary, at least not for Node.js.
See: