Upgrade the rust version to 1.88 - #2583
Merged
Merged
Conversation
orpuente-MS
requested review from
Bill Ticehurst (billti),
Ian Davis (idavis),
Mine Starks (minestarks) and
Stefan J. Wernli (swernli)
as code owners
July 8, 2025 21:29
orpuente-MS
marked this pull request as draft
July 8, 2025 23:06
Bill Ticehurst (billti)
approved these changes
Jul 10, 2025
orpuente-MS
marked this pull request as ready for review
July 10, 2025 17:18
orpuente-MS
enabled auto-merge
July 10, 2025 17:24
Ian Davis (idavis)
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the rust toolchain version from 1.86 to 1.88 across multiple workflows and files. To make the upgrade possible, we had to fix a linker issue and a wasm-config flag that changed in 1.87.
Linker issue
Starting on rust 1.87, the Std doesn't link advapi32 on windows anymore. So, C libraries that depend on it, like mimalloc, now need to link it manually. Link to the Rust PR.
wasm config flag
Rust 1.87 upgraded to LLVM 20, which enables bulk-memory by default. Therefore,
wasm-optneeds to be configured to expect this setting. This behavior is document here.